Skip to content

feat: allow raw keyrings to decrypt with multiple wrapping keys #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2025
Merged

feat: allow raw keyrings to decrypt with multiple wrapping keys #485

merged 4 commits into from
Oct 14, 2025

Conversation

@kessplas
Copy link
Contributor

@kessplas kessplas commented Aug 26, 2025

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@kessplas kessplas marked this pull request as ready for review September 3, 2025 21:50
@kessplas kessplas requested a review from a team as a code owner September 3, 2025 21:50
lucasmcdonald3
lucasmcdonald3 approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I struggled to understand how the title of the PR connected to the content, but eventually understood. I think that moving one (or some) of the tests that decrypt with multiple wrapping keys into examples could be helpful but not totally necessary.

@janSchumacherPayments
Copy link

janSchumacherPayments commented Sep 12, 2025

LGTM -- I struggled to understand how the title of the PR connected to the content, but eventually understood. I think that moving one (or some) of the tests that decrypt with multiple wrapping keys into examples could be helpful but not totally necessary.

I would love to see that. Thats a critical feature IMO

@janSchumacherPayments
Copy link

janSchumacherPayments commented Oct 6, 2025

LGTM -- I struggled to understand how the title of the PR connected to the content, but eventually understood. I think that moving one (or some) of the tests that decrypt with multiple wrapping keys into examples could be helpful but not totally necessary.

@kessplas @lucasmcdonald3 We are desperately waiting for this merge. Is there any movement at all? When can we expect any release on this?

@imabhichow imabhichow merged commit a78cb52 into main Oct 14, 2025
30 of 38 checks passed
@imabhichow imabhichow deleted the multiple-raw-keys branch October 14, 2025 13:08
@atennapel
Copy link

atennapel commented Oct 16, 2025

My team is also eagerly waiting for a new release that includes this PR!

@kessplas
Copy link
Contributor Author

kessplas commented Oct 21, 2025

Hey there, sorry for the delay on this. The team has been working on an unrelated high priority issue. We should be able to release this change by the end of the week. Thank you for your patience.

@kessplas
Copy link
Contributor Author

kessplas commented Oct 24, 2025

Unfortunately our release process is blocked due an issue with one of our dependencies, so we won't be able to complete the release today.

aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Oct 27, 2025
@semantic-release-bot
Amazon S3 Encryption Client 3.5.0 Release -- 2025-10-27
176200c 
## [3.5.0](v3.4.0...v3.5.0) (2025-10-27)

### Features

* allow raw keyrings to decrypt with multiple wrapping keys ([#485](#485)) ([a78cb52](a78cb52))

### Maintenance

* add client specification and Duvet annotations ([#481](#481)) ([1bd8b7a](1bd8b7a))
* move spec submodule to master, update annotations ([#482](#482)) ([cc9eafc](cc9eafc))
* **release:** skip openjdk11 during release validation ([#487](#487)) ([a210653](a210653))
* **spec:** add spec and Duvet annotations for KmsKeyring ([#483](#483)) ([ab41a57](ab41a57))
@kessplas
Copy link
Contributor Author

kessplas commented Oct 27, 2025

Hi @atennapel @janSchumacherPayments ,

This feature is now available in the latest (3.5.0) release of S3EC on Maven.

Feel free to open an issue if you have any further needs or questions.

Thanks again for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasmcdonald3 lucasmcdonald3 lucasmcdonald3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kessplas @janSchumacherPayments @atennapel @lucasmcdonald3 @imabhichow